refactor: adds type annotations reported by mypy and updated pylint v… #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion in .pre-commit-config.yaml
FoamyGuy
requested changes
May 2, 2022
There was a problem hiding this comment.
Thanks for working on this @sabadam32
I have a few things I think we should change mentioned in comments at the relavent code sections.
I also noticed that the issue #6 for this one didn't end up listing all of the functions in this library. I'm not 100% sure why it didn't list more of them, perhaps they were created more recently after that issue was created.
If you're up for it go ahead and add types for the remaining functions: init, display_fahrenheit, display_celsius, temperatures, and battery_level.
If not, that's okay as well I think. Since you did take care of all the ones mentioned in the original issue I think we can get this merged (after the changes other changes mentioned are made) and go back after the fact to get the remaining ones. I don't want to spring them on you since the original issue made it seem like there were fewer. And definitely appreciate any amount of help on it.
Closed
3 tasks
# Conflicts: # .pre-commit-config.yaml
FoamyGuy
approved these changes
May 16, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 21, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.2.0 from 5.1.0: > Patch .pre-commit-config.yaml > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#116 from ryanskeith/add_square_wave > change discord badge > Patch: Replaced discord badge image > Update .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 4.2.1 from 4.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#163 from dannystaple/patch-1 > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#15 from makermelissa/master > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 3.2.0 from 3.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#23 from tannewt/use_real_ntp > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.4 from 2.5.3: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#43 from tannewt/use_real_ntp > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#45 from adafruit/delete-unused-license > Patch .pre-commit-config.yaml Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_iBBQ to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_iBBQ#9 from sabadam32/add_type_annotations_6 > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32S2TFT to 1.1.0 from 1.0.1: > Update .pre-commit-config.yaml > Patch .pre-commit-config.yaml > Merge pull request adafruit/Adafruit_CircuitPython_ESP32S2TFT#6 from FoamyGuy/dont_require_secrets_if_no_network > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Merge pull request adafruit/Adafruit_CircuitPython_ESP32S2TFT#5 from FoamyGuy/fix_circup_instructions Updating https://github.com/adafruit/Adafruit_CircuitPython_OAuth2 to 1.0.7 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_OAuth2#7 from ktkinsey37/typing > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.7.3 from 0.7.2: > Patch .pre-commit-config.yaml > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#49 from jepler/undo-folder-structure > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#48 from jepler/7seg-counter Updating https://github.com/adafruit/Adafruit_CircuitPython_Simple_Text_Display to 1.2.4 from 1.2.3: > Patch .pre-commit-config.yaml > Merge pull request adafruit/Adafruit_CircuitPython_Simple_Text_Display#12 from kattni/docs-fix > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Post-patch cleanup > Consolidate Documentation sections of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ersion in .pre-commit-config.yaml
issue: #6