Remove ready-wait in temperature read. #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
requested changes
Feb 20, 2020
adafruit_adt7410.py
Outdated
| @@ -106,6 +102,11 @@ def configuration(self): | |||
| def configuration(self, val): | |||
| return self._write_register(_ADT7410_CONFIG, val) | |||
|
|
|||
| def _reset(self): | |||
There was a problem hiding this comment.
im ok making this not _ so they can reset at any time
|
github actions ¯_(ツ)_/¯ |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 22, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#8 from caternuson/iss7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notional fix for #7. Also a minor refactor of reset. Unknown if this is actual fix for issue, but at least replicates logic from Arduino library.