refactoring & fix getValues return type #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-mabe
force-pushed
the
get_value_return_extension
branch
from
af744c1 to
452a803
Compare
adaamz
requested changes
Apr 17, 2020
marc-mabe
commented
Apr 17, 2020
…rt MyEnum1|MyEnum2
marc-mabe
force-pushed
the
get_value_return_extension
branch
from
7055df4 to
332a6f1
Compare
|
@adaamz should be fine now ;) |
adaamz
reviewed
Apr 20, 2020
adaamz
reviewed
Apr 20, 2020
adaamz
reviewed
Apr 20, 2020
|
ok, it works on my project so let's merge and improve it later if users found some bugs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnumGetValueDynamicReturnTypeExtensiontoEnumDynamicReturnTypeExtensionConstantArrayTypeofEnum::getValues()MyEnum1|MyEnum2function f(MabeEnum\Enum $enum))