fixed error on Enum type declaration and MyEnum|NoEnum and also support MyEnum1|MyEnum2

Author: marc-mabe

src/EnumDynamicReturnTypeExtension.php

@@ -40,24 +40,34 @@ public function isMethodSupported(MethodReflection $methodReflection): bool
         return in_array(strtolower($methodReflection->getName()), $supportedMethods, true);
     }
 
-    public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): Type
-    {
-        $enumType   = $scope->getType($methodCall->var);
-        $methodName    = $methodReflection->getName();
-        $methodClasses = $enumType->getReferencedClasses();
-        if (count($methodClasses) !== 1) {
-            return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
-        }
+    public function getTypeFromMethodCall(
+        MethodReflection $methodReflection,
+        MethodCall $methodCall,
+        Scope $scope
+    ): Type {
+        $type        = $scope->getType($methodCall->var);
+        $typeClasses = $type->getReferencedClasses();
 
-        $enumeration = $methodClasses[0];
+        $valuesTypeAll = null;
+        foreach ($typeClasses as $typeClass) {
+            if (!is_subclass_of($typeClass, Enum::class, true)) {
+                return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+            }
+
+            $valuesType = $this->getEnumValuesType($typeClass, $scope);
+            $valuesTypeAll = $valuesTypeAll
+                ? TypeCombinator::union($valuesTypeAll, $valuesType)
+                : $valuesType;
+        }
 
+        $methodName = $methodReflection->getName();
         switch (strtolower($methodName)) {
             case 'getvalue':
-                return $this->getEnumValuesType($enumeration, $scope);
+                return $valuesTypeAll;
             case 'getvalues':
                 return new ArrayType(
                     new IntegerType(),
-                    $this->getEnumValuesType($enumeration, $scope)
+                    $valuesTypeAll
                 );
             default:
                 throw new ShouldNotHappenException("Method {$methodName} is not supported");

tests/EnumDynamicReturnTypeExtensionTest.php

@@ -168,4 +168,48 @@ function f(MabeEnumPHPStanTest\Assets\IntTypeEnum $enum) {
 
         $this->processCode($code, '$enum->getName()', 'string', $this->extension);
     }
+
+    public function testBaseEnumTypeMethod(): void
+    {
+        $code = <<<'CODE'
+<?php
+function f(MabeEnum\Enum $enum) {
+    die;
+}
+CODE;
+
+        $this->processCode($code, '$enum->getValue()', 'mixed', $this->extension);
+    }
+
+    public function testMultiEnumClassMethod(): void
+    {
+        $code = <<<'CODE'
+<?php
+use MabeEnumPHPStanTest\Assets\IntTypeEnum;
+use MabeEnumPHPStanTest\Assets\StrTypeEnum;
+
+/** @param IntTypeEnum|StrTypeEnum $enum */
+function f($enum) {
+    die;
+}
+CODE;
+
+        $this->processCode($code, '$enum->getValue()', "0|1|'str1'|'str2'", $this->extension);
+    }
+
+    public function testMultiNonEnumClassMethod(): void
+    {
+        $code = <<<'CODE'
+<?php
+use MabeEnumPHPStanTest\Assets\IntTypeEnum;
+use MabeEnumPHPStanTest\Assets\NotAnEnum;
+
+/** @param IntTypeEnum|NotAnEnum $enum */
+function f($enum) {
+    die;
+}
+CODE;
+
+        $this->processCode($code, '$enum->getValue()', 'mixed', $this->extension);
+    }
 }