Skip to content

Function names to match with routes #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2018
Merged

Function names to match with routes #37

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d937435
Function names to match with routes
arshadkazmi42 Oct 19, 2018
e04cb80
Reverted wrong changes, Made correct function name changes
arshadkazmi42 Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sms/dlr-flask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
app = Flask(__name__)

@app.route('/webhooks/delivery-receipt', methods=['GET', 'POST'])
def delivery_receipt():
def inbound_sms():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not correct. This is the delivery receipt webhook, why are you changing it to inbound sms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked. I did the change other way around. Making this fix now.

if request.is_json:
pprint(request.get_json())
else:
Expand Down
2 changes: 1 addition & 1 deletion voice/handle-user-input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def answer_call():


@app.route("/webhooks/dtmf", methods=['POST'])
def inout_webhook():
def input_webhook():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't need fixing, but if we are going to change it to something we should probably change the function name to dtmf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this change based on the other language sample code NodeJs, 'Java'.
I felt inout_webhook was a type.

Does this change even require?

data = request.get_json()
pprint(data)
ncco =[
Expand Down