Function names to match with routes #37
Conversation
|
@tbedford Can you review + pull the updates in to NDP? |
sms/dlr-flask.py
Outdated
| @@ -4,7 +4,7 @@ | |||
| app = Flask(__name__) | |||
|
|
|||
| @app.route('/webhooks/delivery-receipt', methods=['GET', 'POST']) | |||
| def delivery_receipt(): | |||
| def inbound_sms(): | |||
There was a problem hiding this comment.
Not correct. This is the delivery receipt webhook, why are you changing it to inbound sms?
There was a problem hiding this comment.
Just checked. I did the change other way around. Making this fix now.
voice/handle-user-input.py
Outdated
| @@ -26,7 +26,7 @@ def answer_call(): | |||
|
|
|||
|
|
|||
| @app.route("/webhooks/dtmf", methods=['POST']) | |||
| def inout_webhook(): | |||
| def input_webhook(): | |||
There was a problem hiding this comment.
Didn't need fixing, but if we are going to change it to something we should probably change the function name to dtmf
There was a problem hiding this comment.
I did this change based on the other language sample code NodeJs, 'Java'.
I felt inout_webhook was a type.
Does this change even require?
|
If you look at the original issue: https://github.com/Nexmo/nexmo-developer/issues/1000 You can see that for the inbound sms webhook the associated function was delivery_receipt(). Delivery receipt function name needed to be changed to inbound_sms() so that it matched its associated webhook route. |
|
Thanks! |
Fixes #Nexmo/nexmo-developer
Update function names to match the routes