Skip to content

Fix false naming escaping in JavaScript #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Fix false naming escaping in JavaScript #1952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be9255f
Fixed false escaping
zishkaz Mar 14, 2023
3929b32
Hotfix
zishkaz Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions utbot-js/src/main/kotlin/framework/codegen/model/constructor/visitor/CgJsRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ import org.utbot.framework.codegen.renderer.CgAbstractRenderer
import org.utbot.framework.codegen.renderer.CgPrinter
import org.utbot.framework.codegen.renderer.CgPrinterImpl
import org.utbot.framework.codegen.renderer.CgRendererContext
import org.utbot.framework.codegen.services.language.isLanguageKeyword
import org.utbot.framework.plugin.api.BuiltinMethodId
import org.utbot.framework.plugin.api.ClassId
import org.utbot.framework.plugin.api.TypeParameters
Expand Down Expand Up @@ -409,8 +408,7 @@ internal class CgJsRenderer(context: CgRendererContext, printer: CgPrinter = CgP
print("${exception.name.escapeNamePossibleKeyword()}: ${exception.type}")
}

override fun escapeNamePossibleKeywordImpl(s: String): String =
if (isLanguageKeyword(s, context.cgLanguageAssistant)) "`$s`" else s
override fun escapeNamePossibleKeywordImpl(s: String): String = s

override fun renderClassVisibility(classId: ClassId) {
TODO("Not yet implemented")
Expand Down