Fix false naming escaping in JavaScript #1952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf101
added
comp-codegen
rudolf101
changed the title
Markoutte
requested changes
Mar 15, 2023
| @@ -409,8 +408,7 @@ internal class CgJsRenderer(context: CgRendererContext, printer: CgPrinter = CgP | |||
| print("${exception.name.escapeNamePossibleKeyword()}: ${exception.type}") | |||
| } | |||
|
|
|||
| override fun escapeNamePossibleKeywordImpl(s: String): String = | |||
| if (isLanguageKeyword(s, context.cgLanguageAssistant)) "`$s`" else s | |||
| override fun escapeNamePossibleKeywordImpl(s: String): String = "" | |||
There was a problem hiding this comment.
Why is empty string return?
There was a problem hiding this comment.
This is a mockup for API, JavaScript does not support keyword escaping for function calls
There was a problem hiding this comment.
I ran with this patch the code that has the problem and got this:
it("testDouble1", function ()
{
let = new fileUnderTest.Na("\n\t\n")
let = .()
(0, )
}
)
There was a problem hiding this comment.
Oops, my bad, will be properly fixed soon
Markoutte
requested changes
Mar 15, 2023
Markoutte
approved these changes
Mar 15, 2023
denis-fokin
pushed a commit
that referenced
this pull request
Mar 16, 2023
(cherry picked from commit 50f7fa5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1940
How to test
Manual tests
Various scenarios have been tested. You can find the examples in the folder `/utbot-js/samples' and try to run UTBot.
Self-check list