Skip to content

Add codeforces examples to contest estimator #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 27, 2023

Conversation

mmvpm
Copy link
Collaborator

@mmvpm mmvpm commented Jan 25, 2023

Description

  • Added a new project to projects list for contest estimator.
  • Added a new metric – number of detected exceptions (statistics are printed only if a file with expected exceptions for the project is created)

Fixes #1749

How to test

There is no need to test contest estimator automatically.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@mmvpm mmvpm self-assigned this Jan 25, 2023
@mmvpm mmvpm added ctg-enhancement New feature, improvement or change request comp-contest-estimator Issue is related to contest estimator labels Jan 25, 2023
@mmvpm mmvpm requested a review from sergeypospelov January 25, 2023 13:36
Copy link
Member

@sergeypospelov sergeypospelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ignore the next question, the PR looks acceptablle.

Question is: why don't you use utbot-framework-tests for asserting exceptions? I believe, it's a better place for it. It allows you to assert that UTBot finds custom exceptions in the user code.

Also, this PR may clash with #1751, so I suggets adding @Markoutte as the reviewer.

@mmvpm mmvpm force-pushed the ideaseeker/codeforces_examples branch from 23a743d to 4bc3566 Compare January 27, 2023 10:42
Copy link
Collaborator

@Markoutte Markoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergeypospelov I see no problems with my MR. It won't clash.

@mmvpm mmvpm merged commit 332c215 into main Jan 27, 2023
@mmvpm mmvpm deleted the ideaseeker/codeforces_examples branch January 27, 2023 15:14
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-contest-estimator Issue is related to contest estimator ctg-enhancement New feature, improvement or change request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the detected exceptions metric to Contest Estimator
4 participants