-
Notifications
You must be signed in to change notification settings - Fork 46
Add codeforces examples to contest estimator #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we ignore the next question, the PR looks acceptablle.
Question is: why don't you use utbot-framework-tests
for asserting exceptions? I believe, it's a better place for it. It allows you to assert that UTBot finds custom exceptions in the user code.
Also, this PR may clash with #1751, so I suggets adding @Markoutte as the reviewer.
utbot-junit-contest/src/main/kotlin/org/utbot/contest/Contest.kt
Outdated
Show resolved
Hide resolved
utbot-junit-contest/src/main/kotlin/org/utbot/contest/ContestEstimator.kt
Outdated
Show resolved
Hide resolved
utbot-junit-contest/src/main/kotlin/org/utbot/contest/ContestEstimator.kt
Outdated
Show resolved
Hide resolved
23a743d
to
4bc3566
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergeypospelov I see no problems with my MR. It won't clash.
Description
Fixes #1749
How to test
There is no need to test contest estimator automatically.
Self-check list