Skip to content

Refine AnimatedImage Public APIs to make it more scalable #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 2, 2019
Merged

Refine AnimatedImage Public APIs to make it more scalable #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb7d391
Rmove the unused cross-platforms alias
dreampiggy Nov 2, 2019
3579e7b
Add `onViewDestroy` API, change `onViewUpdate` and `onViewCreate` wit…
dreampiggy Nov 2, 2019
f10bfa7
Update the code documentation for AnimatedImage
dreampiggy Nov 2, 2019
0398267
Simplify the type declaration
dreampiggy Nov 2, 2019
04fc21a
Add the comments about how to use native view update helper
dreampiggy Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Example/SDWebImageSwiftUIDemo/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ struct ContentView: View {
if self.animated {
#if os(macOS) || os(iOS) || os(tvOS)
AnimatedImage(url: URL(string:url))
/**
.onViewUpdate { view, context in
view.toolTip = "Mouseover Tip"
}
*/
.indicator(SDWebImageActivityIndicator.medium)
/**
.placeholder(UIImage(systemName: "photo"))
Expand Down
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ var body: some View {
// Bundle (not Asset Catalog)
AnimatedImage(name: "animation1", isAnimating: $isAnimating)) // Animation control binding
.maxBufferSize(.max)
.onViewUpdate { view, context in // Advanced native view coordinate
view.toolTip = "Mouseover Tip"
}
}
}
```
Expand Down
Loading