Skip to content

Refine AnimatedImage Public APIs to make it more scalable #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 2, 2019

Conversation

dreampiggy
Copy link
Collaborator

Added:

  • static func onViewDestroy(perform action: ((PlatformView, Coordinator) -> Void)? = nil)
  • public var image: PlatformImage?

Break:

  • onViewCreate(perform action: ((PlatformView) -> Void)? = nil) -> AnimatedImage change to onViewCreate(perform action: ((PlatformView, Context) -> Void)? = nil) -> AnimatedImage
  • onViewUpdate(perform action: ((PlatformView) -> Void)? = nil) -> AnimatedImage change to onViewUpdate(perform action: ((PlatformView, Context) -> Void)? = nil) -> AnimatedImage

@dreampiggy dreampiggy force-pushed the refine_animated_image_api branch from 07fbd4c to 04fc21a Compare November 2, 2019 08:47
@dreampiggy dreampiggy added the API API changes label Nov 2, 2019
@dreampiggy dreampiggy merged commit d57fdbb into master Nov 2, 2019
@dreampiggy dreampiggy deleted the refine_animated_image_api branch November 2, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant