Skip to content

Release/v0.5.3 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Release/v0.5.3 #17

merged 2 commits into from
Mar 13, 2020

Conversation

ledyba-z
Copy link
Collaborator

@ledyba-z ledyba-z commented Mar 13, 2020

(Relates to #16 )

Hi, I bumped up the version to v0.5.3, and also, I prepared the release note below. Please use if it's okay:

Release note

Fix

Enhancement

@ledyba-z ledyba-z requested a review from dreampiggy March 13, 2020 06:27
@dreampiggy
Copy link
Collaborator

I'll do this release. Don't need a PR...

I hava a daily job so sometimes may be late 😅 . Most active time is [21:00 ~ 24:00, 10:00 ~ 12:00], UTC 8 Timezone and I'll check the issues.

@dreampiggy dreampiggy merged commit 75b5cd6 into SDWebImage:master Mar 13, 2020
@dreampiggy
Copy link
Collaborator

The release version should be 0.6.0, but not patch version. Because you bump the dependency version, which is not consider a Internel fix user does not recognized...

@dreampiggy
Copy link
Collaborator

@ledyba-z Done v0.6.0 release.

➜  SDWebImageAVIFCoder git:(master) pod trunk info SDWebImageAVIFCoder

SDWebImageAVIFCoder
    - Versions:
      - 0.1.0 (2019-04-14 17:04:59 UTC)
      - 0.2.0 (2019-04-29 10:06:19 UTC)
      - 0.2.1 (2019-08-21 07:30:25 UTC)
      - 0.3.0 (2019-08-21 08:44:57 UTC)
      - 0.4.0 (2019-10-08 05:22:18 UTC)
      - 0.4.2 (2019-10-08 06:58:20 UTC)
      - 0.5.0 (2020-01-24 03:09:13 UTC)
      - 0.5.1 (2020-02-12 06:55:56 UTC)
      - 0.5.2 (2020-02-25 12:23:09 UTC)
      - 0.6.0 (2020-03-13 06:42:09 UTC)
    - Owners:
      - DreamPiggy <lizhuoli1126@126.com>
      - Bogdan Poplauschi <bpoplauschi@gmail.com>

@ledyba-z
Copy link
Collaborator Author

I am so sorry for hurrying you 🙇 .

Actually, I'm not in a hurry.
In this release, there are many changes, so I also prepared the release note.
(However, I am a little worried that libavif v0.6.0 (which is incompatible to v0.5.2) will be installed when SDWebImageAVIFCoder 0.5.2 is installed)

I hava a daily job so sometimes may be late 😅.
Most active time is [21:00 ~ 24:00, 10:00 ~ 12:00], UTC 8 Timezone and I'll check the issues.

Thanks! (Please don't overdo it, I will wait.)

The release version should be 0.6.0, but not patch version. Because you bump the dependency version, which is not consider a Internel fix user does not recognized...

I understand. I will wait you!

@ledyba-z
Copy link
Collaborator Author

@dreampiggy Oh, Thank you so much!

@ledyba-z ledyba-z deleted the release/v0.5.3 branch March 13, 2020 06:47
@dreampiggy
Copy link
Collaborator

dreampiggy commented Mar 13, 2020

It's OK 😅

so I also prepared the release note.

Do you need extra changelog, or something like a CHANGELOG.md for this repo ?

If you think this is OK, we can add one in this repo. Currently you can modify the Release Page information here: 0.6.0

(However, I am a little worried that libavif v0.6.0 (which is incompatible to v0.5.2) will be installed when SDWebImageAVIFCoder 0.5.2 is installed)

This is not part of our task. Actually, it's libavif maintainer's task. They should follow semversion or something. But since semversion only applies to software version >= 1.0.0, so 0.6.0 seems always valid which introduce source break changes :(

@ledyba-z
Copy link
Collaborator Author

Thanks 😂

Do you need extra changelog, or something like a CHANGELOG.md for this repo ?
If you think this is OK, we can add one in this repo. Currently you can modify the Release Page information here: 0.6.0

I think Github Release page is enough and even better.
I added additional information about performance improvement.

This is not part of our task. Actually, it's libavif maintainer's task. They should follow semversion or something. But since semversion only applies to software version >= 1.0.0, so 0.6.0 seems always valid which introduce source break changes :(

Oh.... I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants