Skip to content

Scale alpha planes [0, (1 << bit-depth) - 1] to [0, 65536] #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

ledyba-z
Copy link
Collaborator

@ledyba-z ledyba-z commented Mar 9, 2020

I found that I forgot to scale alpha planes.

In 10bit and 12bit images, alpha plane contains values which ranged from 0 to 1023(10bit) or 4095(12bit).

In this PR, I scale them to 0 to 65535.

@ledyba-z
Copy link
Collaborator Author

ledyba-z commented Mar 9, 2020

Thanks!

@ledyba-z ledyba-z merged commit ab2fde9 into SDWebImage:master Mar 9, 2020
@ledyba-z ledyba-z deleted the fix/hdr-alpha branch March 9, 2020 11:44
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #14 into master will decrease coverage by 0.1%.
The diff coverage is 83.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   86.19%   86.09%   -0.11%     
==========================================
  Files           4        4              
  Lines         971     1014      +43     
==========================================
+ Hits          837      873      +36     
- Misses        134      141       +7
Impacted Files Coverage Δ
SDWebImageAVIFCoder/Classes/SDImageAVIFCoder.m 86.47% <83.72%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c8e95...4713673. Read the comment docs.

@ledyba-z ledyba-z mentioned this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants