Skip to content

Improve Graph Layout and Math Notations in Linear Dynamics Chapter #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 15, 2023

Conversation

HumphreyYang
Copy link
Collaborator

@HumphreyYang HumphreyYang commented Jun 9, 2023

This resolves #238

Hi @shlff, I am stuck at the airport, so I had a first go at fixing some typos and improving the layout of the graphs in this lecture. Please feel free to go for a second round on these lectures.

Many thanks in advance.

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 9afbf9a
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6489e028592aa70008ecb6ac
😎 Deploy Preview https://deploy-preview-240--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

@shlff
Copy link
Member

shlff commented Jun 9, 2023

Thanks for your hard work @HumphreyYang . I'll take a review.

Actually I have been working on cagan_ree and cagan_adaptive in two of my local branches.

Would you mind me to create two separate PRs for these two lectures from those branches? I will shift the corresponding edit from you manually in two commits.

@HumphreyYang
Copy link
Collaborator Author

Would you mind me to create two separate PRs for these two lectures from those branches? I will shift the corresponding edit from you manually in two commits.

Many thanks @shlff, I think you can merge your branch into this branch and push to this branch to add your edits to this PR.

@HumphreyYang
Copy link
Collaborator Author

Hi @shlff,

I have just pushed some other changes to the lectures in this chapter. Could you please kindly have a quick review on these lectures to see if further changes are needed?

equalizing_difference is currently assigned to @maanasee, and I think @maanasee is working hard to review that lecture. Therefore, I only fixed two obvious typos.

Many thanks in advance.

@shlff
Copy link
Member

shlff commented Jun 12, 2023

Thanks @HumphreyYang . Sorry I have been busy catching flights and trains these several days.

I will take a quick review soon.

@HumphreyYang
Copy link
Collaborator Author

HumphreyYang commented Jun 15, 2023

Hi @jstac,

This PR is ready for your review. I will open another PR to break down functions and change double to single quotation.

Many thanks in advance.

@jstac
Copy link
Contributor

jstac commented Jun 15, 2023

Great work @HumphreyYang , many thanks. Merging.

@jstac jstac merged commit 6f7d93b into main Jun 15, 2023
@jstac jstac deleted the improve-cagans branch June 15, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

review Cagan adaptive
3 participants