Move CI to GitHub Actions & split python versions into jobs #603
Conversation
I've switched to a lighter image |
| - if: ${{ matrix.versions.python != '2.6' }} | ||
| run: | | ||
| docker build \ | ||
| . \ | ||
| --build-arg PYTHON_VERSION=${{ matrix.versions.python }} \ | ||
| -t jmadler/python-future-builder:${{ matrix.versions.python }} | ||
| - if: ${{ matrix.versions.python == '2.6' }} | ||
| run: | | ||
| docker build \ | ||
| . \ | ||
| -f 2.6.Dockerfile \ | ||
| -t jmadler/python-future-builder:${{ matrix.versions.python }} |
There was a problem hiding this comment.
If you want to push the images to dockerhub, you might want to use this GitHub action, but it'll require a maintainer to setup the credentials.
There was a problem hiding this comment.
SGTM. @edschofield you may also want to retag as under the PythonCharmers org instead of under my personal profile.
|
This approach LGTM. I'm ok to shave off linting, building for distribution, and fixing remaining tests in error as future work. |
| - if: ${{ matrix.versions.python != '2.6' }} | ||
| run: | | ||
| docker build \ | ||
| . \ | ||
| --build-arg PYTHON_VERSION=${{ matrix.versions.python }} \ | ||
| -t jmadler/python-future-builder:${{ matrix.versions.python }} | ||
| - if: ${{ matrix.versions.python == '2.6' }} | ||
| run: | | ||
| docker build \ | ||
| . \ | ||
| -f 2.6.Dockerfile \ | ||
| -t jmadler/python-future-builder:${{ matrix.versions.python }} |
There was a problem hiding this comment.
SGTM. @edschofield you may also want to retag as under the PythonCharmers org instead of under my personal profile.
# Conflicts: # Dockerfile # build.sh
| # MIME guessing works in Python 3.8! | ||
| guessed_mime = None | ||
| if sys.hexversion >= 0x03080000: | ||
| guessed_mime = "image/gif" |
There was a problem hiding this comment.
That's no longer working apparently
There was a problem hiding this comment.
if sys.version_info >= (3, 8):
There was a problem hiding this comment.
I don't think it's a problem with the condition: the guessed_mime is always None, even on Python 3.8 or 3.9.
My "no longer working" was referring to the code comment:
# MIME guessing works in Python 3.8!
| # _dummy_thread and dummy_threading modules | ||
| # have both been removed in Python 3.9 | ||
| from _thread import * |
There was a problem hiding this comment.
| # Changed in version 3.8: For int operands, the three-argument form | ||
| # of pow now allows the second argument to be negative, permitting | ||
| # computation of modular inverses. | ||
| self.assertEqual(pow(-1, -2, 3), 1) |
There was a problem hiding this comment.
Thanks to Bruno Alla (@browniebroke)
|
Merged (somewhat manually). Thanks, Bruno! |
This pull request builds on top of #601. It is an attempt at rethinking the CI pipeline by splitting each Python version on a separate job.
Given that this project might be supporting EOL Python versions beyond what GitHub is willing to do, I've setup all the jobs to run in Docker, even though only Python 2.6 doesn't seem supported. Sadly, I think this is one of the rare versions to not have an official Docker image.
I've spent some time trying to build one from scratch, but it's much harder than I would expect it to be, mainly because
get-pip.pyisn't working anymore. Here is what I've tried which didn't work:From what I can see, the image
jmadler/python-future-builder:latestworked at the time, because it was built before PyPI changed something around their certificates last year.To workaround this, I'm using that image (which has a lot more than we need), and tell pyenv to use Python 2.6. We cannot do
pip install <package name>as it fails with SSL errors, hence I'm downloading the packages with curl (I took the URLs from the latest green build in Travis), and installing from tarballs/wheels.I think the tests are now running on all versions, but are broken on Python 2.6,
3.8and 3.9.I got rid of the linting script as it was also failing, I can add it back as a separate job (or using pre-commit.ci), but it's probably a separate discussion.