Move CI to Github Actions #601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browniebroke
commented
Mar 15, 2022
Comment on lines
+3
to
+5
| on: | ||
| pull_request: | ||
| push: |
There was a problem hiding this comment.
You probably want to restrict branches before merging this:
Suggested change
| on: | |
| pull_request: | |
| push: | |
| on: | |
| pull_request: | |
| branches: | |
| - master | |
| push: | |
| branches: | |
| - master |
Comment on lines
+7
to
+9
| concurrency: | ||
| group: ${{ github.head_ref || github.run_id }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
This make sure that successive pushes to a PR cancel prior CI runs
browniebroke
force-pushed
the
ci/gh-actions
branch
from
e7af966 to
c3f7a81
Compare
|
FWIW, I tried to explore what's possible if you want to run tests outside of docker on another branch:
This last point means that we should keep things in Docker (unless dropping support for 2.6 is an option, but that probably defies the point of this library) |
|
Closing as superseded by #603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI is still configured to use TravisCI, although it hasn't built in the past 9 months. Since Travis stopped offering generous free plan for open source, most projects have moved to GitHub actions, which seems to be the default these days.
This migrates the existing Travis config to GitHub actions.
The build status isn't reported due to security reasons from GitHub: a workflow added from a fork isn't running. You can see the build result on my fork: https://github.com/browniebroke/python-future/actions/workflows/ci.yml?query=branch%3Aci%2Fgh-actionsActually it seems to be triggering now 👀