Skip to content

Add TransCheX Tutorial #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 20, 2021
Merged

Conversation

ahatamiz
Copy link
Contributor

Signed-off-by: ahatamizadeh ahatamizadeh@nvidia.com

Description

This PR adds the multimodal tutorial for Open-I dataset multilabel disease classification using the TransCheX model.

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ahatamiz ahatamiz requested review from Nic-Ma and wyli December 20, 2021 02:43
@ahatamiz ahatamiz self-assigned this Dec 20, 2021
@ahatamiz ahatamiz added the enhancement New feature or request label Dec 20, 2021
@ahatamiz ahatamiz force-pushed the multimodal-transchex-1 branch from f30eba0 to c93248c Compare December 20, 2021 02:48
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz force-pushed the multimodal-transchex-1 branch from 56b518f to b1310a5 Compare December 20, 2021 02:48
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz force-pushed the multimodal-transchex-1 branch from 475fcd5 to 7e60283 Compare December 20, 2021 03:05
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz force-pushed the multimodal-transchex-1 branch from 5ec79fa to fa25b23 Compare December 20, 2021 03:24
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz force-pushed the multimodal-transchex-1 branch from 6633c1a to 6f075a1 Compare December 20, 2021 03:30
@ahatamiz
Copy link
Contributor Author

Hi @wyli and @Nic-Ma

Is there any way to resolve errors like ' module level import not at top of file ' ? I checked the code cells that pertain to this error, but did not see any anti-pattern. All imports are at the top.

Thanks for your assistance in advance.

@wyli
Copy link
Contributor

wyli commented Dec 20, 2021

Hi @wyli and @Nic-Ma

Is there any way to resolve errors like ' module level import not at top of file ' ? I checked the code cells that pertain to this error, but did not see any anti-pattern. All imports are at the top.

Thanks for your assistance in advance.

I think the formatting requirement is to put all import statements in the first python cell

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz force-pushed the multimodal-transchex-1 branch from 5f370ab to 21d82e6 Compare December 20, 2021 14:51
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz force-pushed the multimodal-transchex-1 branch from 6d5f71e to 87febd0 Compare December 20, 2021 14:58
@ahatamiz
Copy link
Contributor Author

ahatamiz commented Dec 20, 2021

Hi @wyli and @Nic-Ma
Is there any way to resolve errors like ' module level import not at top of file ' ? I checked the code cells that pertain to this error, but did not see any anti-pattern. All imports are at the top.
Thanks for your assistance in advance.

I think the formatting requirement is to put all import statements in the first python cell

Thank you @wyli. I believe this was a bit different than before where imports could have been done in various cells. But I think the PEP8 requirement is very helpful in keeping all tutorials consistent in terms of the code format.

@ahatamiz ahatamiz removed the enhancement New feature or request label Dec 20, 2021
@ahatamiz
Copy link
Contributor Author

Hi @wyli

Would appreciate your review on this one.

Thanks

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me in general. could you please

  • remove the author info (also described here, this is a decision from our dev discussions, the git commit history already tracks the author info.)
  • help testing by running ./runner.sh with a GPU? if it doesn't pass the test, would be great to amend the command here to skip the test:

    tutorials/runner.sh

    Lines 61 to 65 in 4e1e316

    pattern="-and -name '*' -and ! -wholename '*federated_learning*'\
    -and ! -wholename '*unetr_btcv*'\
    -and ! -wholename '*profiling_camelyon*'\
    -and ! -wholename '*profiling_train_base_nvtx*'\
    -and ! -wholename '*benchmark_global_mutual_information*'"

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz force-pushed the multimodal-transchex-1 branch from bdfb1e8 to 3e90934 Compare December 20, 2021 18:19
@ahatamiz
Copy link
Contributor Author

@wyli

Thanks. I have removed the author info. The tutorial requires downloading and preprocessing of the dataset, hence cannot be automatically tested using ./runner.sh . As such, I have added this tutorial to the list for skipping this test.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli merged commit 8a9070a into Project-MONAI:master Dec 20, 2021
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* Add TransCheX Tutorial

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>

* Add TransCheX Tutorial

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>

* Add TransCheX Tutorial

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>

* Add TransCheX Tutorial

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>

* Add TransCheX Tutorial

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>

* Add TransCheX Tutorial

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>

* Add TransCheX Tutorial

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>

* Add TransCheX Tutorial

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants