-
Notifications
You must be signed in to change notification settings - Fork 739
Add TransCheX Tutorial #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
f30eba0
to
c93248c
Compare
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
56b518f
to
b1310a5
Compare
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
475fcd5
to
7e60283
Compare
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
5ec79fa
to
fa25b23
Compare
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
6633c1a
to
6f075a1
Compare
I think the formatting requirement is to put all import statements in the first python cell |
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
5f370ab
to
21d82e6
Compare
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
6d5f71e
to
87febd0
Compare
Thank you @wyli. I believe this was a bit different than before where imports could have been done in various cells. But I think the PEP8 requirement is very helpful in keeping all tutorials consistent in terms of the code format. |
Hi @wyli Would appreciate your review on this one. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me in general. could you please
- remove the author info (also described here, this is a decision from our dev discussions, the git commit history already tracks the author info.)
- help testing by running
./runner.sh
with a GPU? if it doesn't pass the test, would be great to amend the command here to skip the test:Lines 61 to 65 in 4e1e316
pattern="-and -name '*' -and ! -wholename '*federated_learning*'\ -and ! -wholename '*unetr_btcv*'\ -and ! -wholename '*profiling_camelyon*'\ -and ! -wholename '*profiling_train_base_nvtx*'\ -and ! -wholename '*benchmark_global_mutual_information*'"
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
bdfb1e8
to
3e90934
Compare
for more information, see https://pre-commit.ci
Thanks. I have removed the author info. The tutorial requires downloading and preprocessing of the dataset, hence cannot be automatically tested using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me.
* Add TransCheX Tutorial Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com> * Add TransCheX Tutorial Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com> * Add TransCheX Tutorial Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com> * Add TransCheX Tutorial Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com> * Add TransCheX Tutorial Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com> * Add TransCheX Tutorial Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com> * Add TransCheX Tutorial Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com> * Add TransCheX Tutorial Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: ahatamizadeh ahatamizadeh@nvidia.com
Description
This PR adds the multimodal tutorial for Open-I dataset multilabel disease classification using the TransCheX model.
Status
Ready
Checks
./runner [-p <regex_pattern>]