-
Notifications
You must be signed in to change notification settings - Fork 739
Add generative model metrics notebook #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generative model metrics notebook #1771
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Hi @ericspod @KumoLiu Do you have any suggestions? Can we use other weights to replace it?
it seems the 2d_ldm weights can be used, can we prepare a copy for users to download? |
@marksgraham would you have the file that was stored in your google drive? We can rehost it somewhere else perhaps and get this added. |
Sorry I deleted them in a bulk drive clearout, without realising they were still being used here. It is easy to regenerate the checkpoint by running the tutorial with |
Hi @marksgraham , thanks for the info. Can I confirm that we at least need to use trained |
Hi @yiheng-wang-nv yes they will need to be trained too. You should be able to get trained versions for both of the sets of weights using this tutorial |
Thanks @marksgraham , I will run 2d_ldm tutorial, and save weights into https://github.com/Project-MONAI/MONAI-extra-test-data, then we can use that links in the metric tutorial. cc @ericspod @KumoLiu |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
bbce5fc
to
b221e3e
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Hi @ericspod , do you have any experiences on this error: https://github.com/Project-MONAI/tutorials/actions/runs/10400120252/job/28800115713?pr=1771#step:5:710 |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
I guess the CI machine may have some issues when load radimagenet weights, I changed to use torchvision's resnet50 as the feature extractor, and now tests pass. |
I think the update here should be fine since the notebook is mainly talk about the metric used in the generative model. What do you think? @ericspod |
If you can get it to work with another network let's go with that. For the future this is related to numerical error with |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Fixes #1770 .
Description
A few sentences describing the changes proposed in this pull request.
Checks
./figure
folder./runner.sh -t <path to .ipynb file>