Skip to content

Update package-lock.json for 2020.7.0 #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jul 23, 2020

PR Summary

Based on #2828, but I ran the build to update the package-lock.json as well as npm audit fix.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister
Copy link
Contributor

Happy to take that PR alternatively as well, I didn't know about the audit option of npm

@rjmholt
Copy link
Contributor Author

rjmholt commented Jul 23, 2020

I didn't know about the audit option of npm

It just told me when I ran a clean build -- seemed like a good idea

@rjmholt
Copy link
Contributor Author

rjmholt commented Jul 23, 2020

Closing in favour of #2828

@rjmholt rjmholt closed this Jul 23, 2020
@rjmholt rjmholt deleted the update-deps branch July 23, 2020 16:28
@bergmeister
Copy link
Contributor

Closing in favour of #2828

Why? My PR does not contain the audit fixes. Ideally my PR should be just the version fix and yours the audit fix.

@rjmholt
Copy link
Contributor Author

rjmholt commented Jul 23, 2020

Why? My PR does not contain the audit fixes. Ideally my PR should be just the version fix and yours the audit fix.

I've added the audit fixes to your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants