Skip to content

Update version in package.lock.json to 2020.7.0 and resolve npm audit warnings #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

bergmeister
Copy link
Contributor

PR Summary

When you bump versions, do you have a script that does it? Because it should do it for both package.json and package.lock.json.
This keeps coming up that package.lock.json gets behind but is a tad annoying as it shows as a diff when doing a clean re-compile...

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@rjmholt
Copy link
Contributor

rjmholt commented Jul 23, 2020

We should actually be running npm when package.json is updated to ensure all packages are updated properly. The problem isn't that a script is updating the package.json, it's that we're not running the thing that updates the package-lock.json

@bergmeister
Copy link
Contributor Author

The build itself uses npm, which updates the package-lock.json but only in the case of clean build where there is no local node_modules cache

@rjmholt
Copy link
Contributor

rjmholt commented Jul 23, 2020

The build itself uses npm, which updates the package-lock.json

Oh I mean that we're not running the build when package.json is updated, and we should

@rjmholt rjmholt requested a review from TylerLeonhardt July 23, 2020 16:30
@bergmeister bergmeister changed the title Update version in package.lock.json to 2020.7.0 Update version in package.lock.json to 2020.7.0 and resolve npm audit warnings Jul 23, 2020
@TylerLeonhardt TylerLeonhardt merged commit 7e29af3 into PowerShell:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants