Replace superfluous Default member with default values
#1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No clue why that CI failed, everything passes locally. Rerunning. |
You just mean that there isn't likely to be a lot of initialization involved right? Just clarifying because a record is just sugar for a class with some extra methods and an interface defined. It's still extra heap allocations. That said, it's just some extra heap allocations that are unlikely to even be measurable so if you prefer it I don't feel strongly either way. |
andyleejordan
force-pushed
the
andschwa/remove-default-member
branch
from
2f1426d to
5005c0f
Compare
SeeminglyScience
approved these changes
Feb 2, 2022
|
Damn, I want to know what's up with the CI...it doesn't fail locally 😅 |
andyleejordan
force-pushed
the
andschwa/remove-default-member
branch
3 times, most recently
from
96ab79f to
2001001
Compare
|
@SeeminglyScience Tracked down the source of the failure and it was because we actually needed to do the null coalescing in the |
I think this was a case of premature optimization. We're using C# records, which should be as cheap as an object as they come, especially when we can rely on the compiler for default values. Now we're passing fewer objects around too.
andyleejordan
force-pushed
the
andschwa/remove-default-member
branch
from
2001001 to
d7ca65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was a case of premature optimization. We're using C#
records, which should be as cheap as an object as they come, especially
when we can rely on the compiler for default values. Now we're passing
fewer objects around too.