Replace superfluous Default member with default values

I think this was a case of premature optimization. We're using C#
records, which should be as cheap as an object as they come, especially
when we can rely on the compiler for default values. Now we're passing
fewer objects around too.

Author: andyleejordan

src/PowerShellEditorServices/Services/Extension/ExtensionService.cs

@@ -107,7 +107,7 @@ internal Task InitializeAsync()
             // Register the editor object in the runspace
             return ExecutionService.ExecuteDelegateAsync(
                 $"Create ${PSEditorVariableName} object",
-                ExecutionOptions.Default,
+                executionOptions: null,
                 (pwsh, _) => pwsh.Runspace.SessionStateProxy.PSVariable.Set(psEditor),
                 CancellationToken.None);
         }

src/PowerShellEditorServices/Services/PowerShell/Console/LegacyReadLine.cs

@@ -84,14 +84,14 @@ public override string ReadLine(CancellationToken cancellationToken)
                                         .AddParameter("CursorColumn", currentCursorIndex)
                                         .AddParameter("Options", null);
 
-                                    currentCompletion = _psesHost.InvokePSCommand<CommandCompletion>(command, PowerShellExecutionOptions.Default, cancellationToken).FirstOrDefault();
+                                    currentCompletion = _psesHost.InvokePSCommand<CommandCompletion>(command, executionOptions: null, cancellationToken).FirstOrDefault();
                                 }
                                 else
                                 {
                                     currentCompletion = _psesHost.InvokePSDelegate(
                                         "Legacy readline inline command completion",
-                                        ExecutionOptions.Default,
-                                        (pwsh, cancellationToken) => CommandCompletion.CompleteInput(inputAfterCompletion, currentCursorIndex, options: null, pwsh),
+                                        executionOptions: null,
+                                        (pwsh, _) => CommandCompletion.CompleteInput(inputAfterCompletion, currentCursorIndex, options: null, pwsh),
                                         cancellationToken);
 
                                     if (currentCompletion.CompletionMatches.Count > 0)
@@ -198,7 +198,7 @@ public override string ReadLine(CancellationToken cancellationToken)
                                 PSCommand command = new PSCommand()
                                     .AddCommand("Get-History");
 
-                                currentHistory = _psesHost.InvokePSCommand<PSObject>(command, PowerShellExecutionOptions.Default, cancellationToken);
+                                currentHistory = _psesHost.InvokePSCommand<PSObject>(command, executionOptions: null, cancellationToken);
 
                                 if (currentHistory != null)
                                 {

src/PowerShellEditorServices/Services/PowerShell/Debugging/DscBreakpointCapability.cs

@@ -164,7 +164,7 @@ public static Task<DscBreakpointCapability> GetDscCapabilityAsync(
 
             return psesHost.ExecuteDelegateAsync<DscBreakpointCapability>(
                 nameof(getDscBreakpointCapabilityFunc),
-                ExecutionOptions.Default,
+                executionOptions: null,
                 getDscBreakpointCapabilityFunc,
                 cancellationToken);
         }

src/PowerShellEditorServices/Services/PowerShell/Execution/ExecutionOptions.cs

@@ -15,39 +15,16 @@ public enum ExecutionPriority
     // Generally the executor will do the right thing though; some options just priority over others.
     public record ExecutionOptions
     {
-        public static ExecutionOptions Default = new()
-        {
-            Priority = ExecutionPriority.Normal,
-            MustRunInForeground = false,
-            InterruptCurrentForeground = false,
-        };
-
-        public ExecutionPriority Priority { get; init; }
-
+        public ExecutionPriority Priority { get; init; } = ExecutionPriority.Normal;
         public bool MustRunInForeground { get; init; }
-
         public bool InterruptCurrentForeground { get; init; }
     }
 
     public record PowerShellExecutionOptions : ExecutionOptions
     {
-        public static new PowerShellExecutionOptions Default = new()
-        {
-            Priority = ExecutionPriority.Normal,
-            MustRunInForeground = false,
-            InterruptCurrentForeground = false,
-            WriteOutputToHost = false,
-            WriteInputToHost = false,
-            ThrowOnError = true,
-            AddToHistory = false,
-        };
-
         public bool WriteOutputToHost { get; init; }
-
         public bool WriteInputToHost { get; init; }
-
-        public bool ThrowOnError { get; init; }
-
+        public bool ThrowOnError { get; init; } = true;
         public bool AddToHistory { get; init; }
     }
 }

src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs

@@ -307,7 +307,7 @@ public Task<TResult> ExecuteDelegateAsync<TResult>(
             Func<PowerShell, CancellationToken, TResult> func,
             CancellationToken cancellationToken)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousPSDelegateTask<TResult>(_logger, this, representation, executionOptions ?? ExecutionOptions.Default, func, cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(new SynchronousPSDelegateTask<TResult>(_logger, this, representation, executionOptions ?? new ExecutionOptions(), func, cancellationToken));
         }
 
         public Task ExecuteDelegateAsync(
@@ -316,7 +316,7 @@ public Task ExecuteDelegateAsync(
             Action<PowerShell, CancellationToken> action,
             CancellationToken cancellationToken)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousPSDelegateTask(_logger, this, representation, executionOptions ?? ExecutionOptions.Default, action, cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(new SynchronousPSDelegateTask(_logger, this, representation, executionOptions ?? new ExecutionOptions(), action, cancellationToken));
         }
 
         public Task<TResult> ExecuteDelegateAsync<TResult>(
@@ -325,7 +325,7 @@ public Task<TResult> ExecuteDelegateAsync<TResult>(
             Func<CancellationToken, TResult> func,
             CancellationToken cancellationToken)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousDelegateTask<TResult>(_logger, representation, executionOptions ?? ExecutionOptions.Default, func, cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(new SynchronousDelegateTask<TResult>(_logger, representation, executionOptions ?? new ExecutionOptions(), func, cancellationToken));
         }
 
         public Task ExecuteDelegateAsync(
@@ -334,7 +334,7 @@ public Task ExecuteDelegateAsync(
             Action<CancellationToken> action,
             CancellationToken cancellationToken)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousDelegateTask(_logger, representation, executionOptions ?? ExecutionOptions.Default, action, cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(new SynchronousDelegateTask(_logger, representation, executionOptions ?? new ExecutionOptions(), action, cancellationToken));
         }
 
         public Task<IReadOnlyList<TResult>> ExecutePSCommandAsync<TResult>(
@@ -346,7 +346,7 @@ public Task<IReadOnlyList<TResult>> ExecutePSCommandAsync<TResult>(
                 _logger,
                 this,
                 psCommand,
-                executionOptions ?? PowerShellExecutionOptions.Default,
+                executionOptions ?? new PowerShellExecutionOptions(),
                 cancellationToken));
         }
 
@@ -660,7 +660,7 @@ private void DoOneRepl(CancellationToken cancellationToken)
         private string GetPrompt(CancellationToken cancellationToken)
         {
             var command = new PSCommand().AddCommand("prompt");
-            IReadOnlyList<string> results = InvokePSCommand<string>(command, PowerShellExecutionOptions.Default, cancellationToken);
+            IReadOnlyList<string> results = InvokePSCommand<string>(command, executionOptions: null, cancellationToken);
             string prompt = results.Count > 0 ? results[0] : DefaultPrompt;
 
             if (CurrentRunspace.RunspaceOrigin != RunspaceOrigin.Local)
@@ -844,7 +844,7 @@ private void OnPowerShellIdle(CancellationToken idleCancellationToken)
             // to force event processing
             if (runPipelineForEventProcessing)
             {
-                InvokePSCommand(new PSCommand().AddScript("0", useLocalScope: true), PowerShellExecutionOptions.Default, CancellationToken.None);
+                InvokePSCommand(new PSCommand().AddScript("0", useLocalScope: true), executionOptions: null, CancellationToken.None);
             }
         }
 

src/PowerShellEditorServices/Services/PowerShell/Utility/CommandHelpers.cs

@@ -183,7 +183,7 @@ public static async Task<string> GetCommandSynopsisAsync(
 
             IEnumerable<CommandInfo> aliases = await executionService.ExecuteDelegateAsync<IEnumerable<CommandInfo>>(
                 nameof(GetAliasesAsync),
-                Execution.ExecutionOptions.Default,
+                executionOptions: null,
                 (pwsh, _) =>
                 {
                     CommandInvocationIntrinsics invokeCommand = pwsh.Runspace.SessionStateProxy.InvokeCommand;

src/PowerShellEditorServices/Services/Workspace/RemoteFileManagerService.cs

@@ -657,8 +657,8 @@ private async void HandlePSEventReceivedAsync(object sender, PSEventArgs args)
         private Task RegisterPSEditFunctionAsync()
             => _executionService.ExecuteDelegateAsync(
                 "Register psedit function",
-                ExecutionOptions.Default,
-                (pwsh, cancellationToken) => RegisterPSEditFunction(pwsh.Runspace),
+                executionOptions: null,
+                (pwsh, _) => RegisterPSEditFunction(pwsh.Runspace),
                 CancellationToken.None);
 
         private void RegisterPSEditFunction(Runspace runspace)