Fix AvoidInternalURLs throw warnings at SDDL #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take bug fixes to Master
Add Tests for UseShouldProcessForStateChangingFunctions
Remove check for "Get-'" Get does not modify system Status
Conflicts: Rules/UseShouldProcessForStateChangingFunctions.cs
[4/17] Take this week's bug fixes to Master branch
| if (count !=3 ) | ||
| { | ||
| isInternalURL = true; | ||
| } |
There was a problem hiding this comment.
I think an SDDL can actually have 4 ":"
This is because they can have both DACL and SACL components (SACL is optional, I think)
In the test case, the string only has the DACL component.
https://msdn.microsoft.com/en-us/library/windows/desktop/aa379570(v=vs.85).aspx
|
Thanks Quoc. I've changed the count to check both 3 and 4. |
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| ##Description | |||
|
|
|||
| Functions that have verbs like New, Start, Stop, Set, Reset that change system state should support 'ShouldProcess' | |||
| Functions that have verbs like New, Start, Stop, Set, Reset and Restart that change system state should support 'ShouldProcess' | |||
There was a problem hiding this comment.
Why is file in the current change?
There was a problem hiding this comment.
I committed the changes earlier to BugFixes by accident so I reverted the changes. This file may be reverted as well.
|
looks good. |
|
Looks good to me too. |
yutingc
added a commit
that referenced
this pull request
Apr 20, 2015
Fix AvoidInternalURLs throw warnings at SDDL
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.