Skip to content

refactor: use not so generic names #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2019
Merged

refactor: use not so generic names #36

merged 2 commits into from
Jun 27, 2019

Conversation

tgpetrov
Copy link
Contributor

PR Checklist

What is the current behavior?

  • There is a possible conflict when using generic method names like updateHandler. Follow-up of this PR
  • Information about the expected format of date and time strings is not clear.

What is the new behavior?

  • Name of a method is changed to decrease the chance of conflicts.
  • The explanation about supported date/time formats is extended.

Fixes/Implements/Closes #[Issue Number].

@tgpetrov tgpetrov requested a review from a team June 27, 2019 07:02
@cla-bot cla-bot bot added the cla: yes label Jun 27, 2019
@tgpetrov tgpetrov merged commit cb4b41f into master Jun 27, 2019
@tgpetrov tgpetrov deleted the tgpetrov/feedback branch June 27, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants