Skip to content

refactor(EditableTextBase, Button) rename PseudoClass update handlers to be more specific #7404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2019

Conversation

bundyo
Copy link
Contributor

@bundyo bundyo commented Jun 25, 2019

Rename the PseudoClass update handler names to something more specific
as the TextField method clashes with DateTimePicker plugin method
with the same name, causing its tap handler to be called several times.

PR Checklist

What is the new behavior?

No change in behavior, just rename the private methods to be more specific.

 as the TextField method clashes with DateTimePicker plugin method
 with the same name.
@bundyo bundyo added the bug label Jun 25, 2019
@bundyo bundyo self-assigned this Jun 25, 2019
@cla-bot cla-bot bot added the cla: yes label Jun 25, 2019
@bundyo bundyo changed the title fix(EditableTextBase, Button) Rename the PseudoClass update handlers to be more specific refactor(EditableTextBase, Button) Rename the PseudoClass update handlers to be more specific Jun 25, 2019
@manoldonev manoldonev changed the title refactor(EditableTextBase, Button) Rename the PseudoClass update handlers to be more specific refactor(EditableTextBase, Button) rename PseudoClass update handlers to be more specific Jun 26, 2019
@manoldonev manoldonev merged commit 1a0c81f into master Jun 26, 2019
@manoldonev manoldonev deleted the bundev/more-specific-handler-names branch June 26, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants