Show user friendly message when the plugin is not supported for installed platform #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| if(semver.gt(pluginVersion, installedFrameworkVersion)) { | ||
| if(!pluginVersion) { | ||
| this.$logger.warn(`${pluginData.name} is not supported for ${platform}.`); | ||
| skipExecution = true; |
There was a problem hiding this comment.
Can't you simply return from the function?
There was a problem hiding this comment.
Yes, we can. I've just fixed it.
Fatme
force-pushed
the
fatme/fix-pl-message
branch
from
4632972 to
019631e
Compare
|
✅ |
|
👍 after green build |
|
👍 |
Fatme
pushed a commit
that referenced
this pull request
Jun 16, 2015
Show user friendly message when the plugin is not supported for installed platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.