Skip to content

Commit 4632972

Browse files
Fatme HavaluovaFatme Havaluova
Fatme Havaluova
authored and
Fatme Havaluova
committed
Show user friendly message when the plugin is not supported for installed platform
1 parent 8f6247a commit 4632972

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

lib/services/plugins-service.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@ export class PluginsService implements IPluginsService {
6767
let pluginPlatformsData = pluginData.platformsData;
6868
if(pluginPlatformsData) {
6969
let pluginVersion = (<any>pluginPlatformsData)[platform];
70-
if(semver.gt(pluginVersion, installedFrameworkVersion)) {
70+
if(!pluginVersion) {
71+
this.$logger.warn(`${pluginData.name} is not supported for ${platform}.`);
72+
skipExecution = true;
73+
}
74+
75+
if(!skipExecution && semver.gt(pluginVersion, installedFrameworkVersion)) {
7176
this.$logger.warn(`${pluginData.name} ${pluginVersion} for ${platform} is not compatible with the currently installed framework version ${installedFrameworkVersion}.`);
7277
skipExecution = true;
7378
}

0 commit comments

Comments
 (0)