Skip to content

Apply fixes from StyleCI #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Apply fixes from StyleCI #840

merged 1 commit into from
Jan 12, 2020

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Jan 11, 2020

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

@acrobat acrobat closed this Jan 11, 2020
@acrobat acrobat deleted the analysis-YjOWdv branch January 11, 2020 20:12
@GrahamCampbell
Copy link
Contributor

?

@GrahamCampbell GrahamCampbell mentioned this pull request Jan 11, 2020
@acrobat
Copy link
Collaborator Author

acrobat commented Jan 11, 2020

Huh, I didn’t close this 🤔 Let me check that tomorrow!

@GrahamCampbell
Copy link
Contributor

Should be possible to re-open and merge from the GitHub UI.

@acrobat acrobat restored the analysis-YjOWdv branch January 12, 2020 10:58
@acrobat
Copy link
Collaborator Author

acrobat commented Jan 12, 2020

Yes I know, but I wanted to check if I could see why this was closed! I don't understand it, I didn't close it and I didn't delete the branch for sure 😄 @GrahamCampbell do you know if styleci maybe removes the branch after some time? Maybe this causes the pr to be closed?

But I've restored the branch and reopend the pr, when all the checks pass the PR will be merged!

@acrobat acrobat reopened this Jan 12, 2020
@acrobat acrobat merged commit 2a4def8 into master Jan 12, 2020
@acrobat acrobat deleted the analysis-YjOWdv branch January 12, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants