Code Style

[GrahamCampbell]

Replaces #817.

[acrobat]

I wouldn't actually remove the php_cs config, but make it as close as possible to the styleci config. This will allow users to run php-cs-fixer locally before committing/creating a PR and actually have the code style correctly applied.

Styleci will catch the remaning issues and make sure PR's don't get merged with code style issues.

[GrahamCampbell]

I disagree with the sentiment of making contributors care about code style. StyleCI is there to automatically fix it for maintainers.

[kubawerlos]

@acrobat it's one way or another - PHP CS Fixer with it's config or relying on Style CI - having both is IMHO the worst solution.

This will allow users to run php-cs-fixer locally before committing/creating a PR

And that's why I prefer having PHP CS Fixer in the repo, so code style can be fixed before merging PR, not after.

[kubawerlos]

Can you also remove PHP CS Fixer's cache from .gitignore?

[GrahamCampbell]

Ping.

[kubawerlos]

Pong.

What about the question above "ping"?

[GrahamCampbell]

I'm no longer able to edit this PR.

[GrahamCampbell]

And keeping the cache file ignored is fine. I don't think we should remove this, otherwise when someone does a git pull, they may accidentality commit the cache file.

[kubawerlos]

they may accidentality commit the cache file

sounds like a cheap excuse for bearing lazy ;)

[GrahamCampbell]

Ping @acrobat. :)

[acrobat]

Sorry I've lost track of this PR! Thanks @GrahamCampbell!

[kubawerlos]

@GrahamCampbell what should happen after the merge to fix the failing job https://github.styleci.io/analyses/YjOWdv?

[GrahamCampbell]

StyleCI sends over a PR to be merged. It looks like it was closed.

[GrahamCampbell]

#840