Skip to content

Add sizes selection to runner py #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 1, 2022
Merged

Add sizes selection to runner py #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88565f8
sizes in configs
dmitrii-kriukov Dec 29, 2021
e668d94
test config
dmitrii-kriukov Jan 12, 2022
6272ea5
knn_svm
dmitrii-kriukov Jan 17, 2022
81868d3
Revert "knn_svm"
dmitrii-kriukov Jan 17, 2022
669f82e
revert changing skl config
dmitrii-kriukov Jan 19, 2022
a40add9
Merge branch 'master' of https://github.com/dmitrii-kriukov/scikit-le…
dmitrii-kriukov Jan 19, 2022
08a66ee
sizes for df_clsf
dmitrii-kriukov Jan 19, 2022
caf5888
update help info
dmitrii-kriukov Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions configs/xpu/df_clsf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
}
}
],
"workload-size": "medium",
"num-trees": 10,
"max-depth": 5
},
Expand All @@ -46,6 +47,7 @@
}
}
],
"workload-size": "large",
"num-trees": 100,
"max-depth": 8
},
Expand All @@ -66,6 +68,7 @@
}
}
],
"workload-size": "medium",
"num-trees": 20,
"max-depth": 16
},
Expand All @@ -86,6 +89,7 @@
}
}
],
"workload-size": "large",
"num-trees": 100,
"max-depth": 10
},
Expand All @@ -106,6 +110,7 @@
}
}
],
"workload-size": "medium",
"num-trees": 50,
"max-depth": 15
}
Expand Down
10 changes: 10 additions & 0 deletions runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ def get_configs(path: Path) -> List[str]:
help='Available floating point data types'
'This parameter only marks dtype as available, '
'make sure to add the dtype parameter to the config file ')
parser.add_argument('--workload-size', type=str, default="small medium large", nargs='+',
choices=("small", "medium", "large"),
help='Available workload sizes,'
'make sure to add the workload-size parameter to the config file '
'unmarked workloads will be launched anyway')
parser.add_argument('--no-intel-optimized', default=False, action='store_true',
help='Use Scikit-learn without Intel optimizations')
parser.add_argument('--output-file', default='results.json',
Expand Down Expand Up @@ -105,6 +110,11 @@ def get_configs(path: Path) -> List[str]:
params = common_params.copy()
params.update(params_set.copy())

if 'workload-size' in params:
if params['workload-size'] not in args.workload_size:
continue
del params['workload-size']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better here to use dictionary own methods to remove instead of using del for removing object. It seems that your addition are consistent with other same cases in this script code. This is out of the scope for the current PR, but it would be better to fix this kind of thing in other PR(s).


device = []
if 'device' not in params:
if 'sklearn' in params['lib']:
Expand Down