Add sizes selection to runner py #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6272ea5.
vlad-nazarov
approved these changes
Jan 19, 2022
dmitrii-kriukov
requested review from
Pahandrovich,
samir-nasibli and
Alexsandruss
| if 'workload-size' in params: | ||
| if params['workload-size'] not in args.workload_size: | ||
| continue | ||
| del params['workload-size'] |
There was a problem hiding this comment.
It is better here to use dictionary own methods to remove instead of using del for removing object. It seems that your addition are consistent with other same cases in this script code. This is out of the scope for the current PR, but it would be better to fix this kind of thing in other PR(s).
Alexsandruss
approved these changes
Jan 21, 2022
samir-nasibli
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameters to runner.py that define sizes of running datasets.
Size parameter may be defined in cases in config file, if size is not defined, case will be launched anyway