Skip to content

Enable tests for dpnp.einsum since dpctl issue is resolved #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

Enable tests for dpnp.einsum since dpctl issue is resolved #2425

merged 3 commits into from
Apr 24, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 23, 2025 •
edited
Loading

dpctl-2055 has been resolved by dpctl-2058.
This PR enables previously muted tests for dpnp.einsum failing due to dpctl issue.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Apr 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Apr 23, 2025 •
edited
Loading

Coverage Status

coverage: 72.271%. remained the same
when pulling c3289ef on enable-einsum-tests
into eddd826 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_9 ran successfully.
Passed: 1222
Failed: 0
Skipped: 9

@antonwolfy antonwolfy marked this pull request as ready for review April 24, 2025 11:43
vlad-perevezentsev
vlad-perevezentsev approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit d65ad95 into master Apr 24, 2025
68 checks passed
@antonwolfy antonwolfy deleted the enable-einsum-tests branch April 24, 2025 12:33
github-actions bot added a commit that referenced this pull request Apr 24, 2025
@github-actions
Enable tests for dpnp.einsum since dpctl issue is resolved (#2425)
104038b 
[dpctl-2055](IntelPython/dpctl#2055) has been
resolved by
[dpctl-2058](IntelPython/dpctl#2058).
This PR enables previously muted tests for `dpnp.einsum` failing due to
dpctl issue. d65ad95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vlad-perevezentsev