Skip to content

Resolve gh-2055 #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2025
Merged

Resolve gh-2055 #2058

merged 6 commits into from
Apr 24, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Apr 17, 2025 •
edited
Loading

This PR fixes a bug in asarray where order="K" keyword could fail to produce an appropriate array in some edge cases, such as the permutation of a contiguous array.

asarray(x) for some NumPy array x now uses a consistent implementation for order="K" as other functions supporting order

Closes #2055

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_147 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

1 similar comment
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_147 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Apr 17, 2025 •
edited
Loading

Coverage Status

coverage: 86.419% (+0.009%) from 86.41%
when pulling 152a3ed on resolve-gh-2055
into 6ac3a8f on master.

@ndgrigorian ndgrigorian force-pushed the resolve-gh-2055 branch 2 times, most recently from bfd9dd0 to 93d288c Compare April 21, 2025 21:40
@ndgrigorian ndgrigorian marked this pull request as ready for review April 21, 2025 21:43
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_153 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

antonwolfy
antonwolfy reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In overall, I can confirm that the original issue is gone and all dpnp tests passed with that change.
Thank you @ndgrigorian for resolving this.

@antonwolfy antonwolfy mentioned this pull request Apr 23, 2025
Merged
7 tasks
@ndgrigorian ndgrigorian requested a review from antonwolfy April 23, 2025 21:38
antonwolfy
antonwolfy approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_158 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@ndgrigorian ndgrigorian merged commit 8dcc44f into master Apr 24, 2025
74 of 75 checks passed
@ndgrigorian ndgrigorian deleted the resolve-gh-2055 branch April 24, 2025 00:05
antonwolfy added a commit to IntelPython/dpnp that referenced this pull request Apr 24, 2025
@antonwolfy
Enable tests for dpnp.einsum since dpctl issue is resolved (#2425)
d65ad95 
[dpctl-2055](IntelPython/dpctl#2055) has been
resolved by
[dpctl-2058](IntelPython/dpctl#2058).
This PR enables previously muted tests for `dpnp.einsum` failing due to
dpctl issue.
github-actions bot added a commit to IntelPython/dpnp that referenced this pull request Apr 24, 2025
@github-actions
Enable tests for dpnp.einsum since dpctl issue is resolved (#2425)
104038b 
[dpctl-2055](IntelPython/dpctl#2055) has been
resolved by
[dpctl-2058](IntelPython/dpctl#2058).
This PR enables previously muted tests for `dpnp.einsum` failing due to
dpctl issue. d65ad95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpt.asarray failed to copy input numpy.ndarray
3 participants
@ndgrigorian @coveralls @antonwolfy