Skip to content

Resolve issues in public CI #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 11, 2025
Merged

Resolve issues in public CI #2254

merged 9 commits into from
Jan 11, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 10, 2025

The PR proposes to implement fixes/improvements into the public CI:

  • run pre-commit and building docs workflows on Ubuntu-22.04 (ubuntu-latest now refers to Ubuntu-24.04 where the workflows fail as for now)
  • use fail-fast: false rather than continue-on-error: false in workflow with night tests run (some jobs in strategy matrix may fail due to mamba/conda issues)
    Note, the workflow will be reported as failed if any job fails.
  • trigger rerun tests step on failure of run_tests step only in night tests workflow
  • trigger resetup minoconda step on failure in night tests and conda package workflows
  • build name of running job based on python and OS from strategy matrix
  • disable night tests workflow to be run in forked repositories

Also the PR includes adaptation to the recent interface changes in dpctl implemented in gh-1957.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jan 10, 2025

Coverage Status

coverage: 65.087% (+0.007%) from 65.08%
when pulling a571e06 on stabilize-public-ci
into e8c088c on master.

@antonwolfy antonwolfy force-pushed the stabilize-public-ci branch 2 times, most recently from 38e2e49 to 42cafec Compare January 10, 2025 14:37
@antonwolfy antonwolfy marked this pull request as ready for review January 10, 2025 23:25
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy
Copy link
Contributor Author

GH workflow for nightly run passed:
https://github.com/IntelPython/dpnp/actions/runs/12723513290

@antonwolfy antonwolfy merged commit 303a203 into master Jan 11, 2025
72 of 73 checks passed
@antonwolfy antonwolfy deleted the stabilize-public-ci branch January 11, 2025 12:53
github-actions bot added a commit that referenced this pull request Jan 11, 2025
The PR proposes to implement fixes/improvements into the public CI:
- run `pre-commit` and `building docs` workflows on Ubuntu-22.04
(`ubuntu-latest` now refers to Ubuntu-24.04 where the workflows fail as
for now)
- use `fail-fast: false` rather than `continue-on-error: false` in
workflow with night tests run (some jobs in strategy matrix may fail due
to mamba/conda issues)
_Note, the workflow will be reported as failed if any job fails._
- trigger rerun tests step on failure of `run_tests` step only in night
tests workflow
- trigger resetup minoconda step on failure in night tests and conda
package workflows
- build name of running job based on python and OS from strategy matrix
- disable night tests workflow to be run in forked repositories

Also the PR includes adaptation to the recent interface changes in dpctl
implemented in
[gh-1957](IntelPython/dpctl#1957). 303a203
antonwolfy added a commit that referenced this pull request Jan 13, 2025
The PR proposes to add fixes/improvements into the public CI:
- trigger resetup miniconda step on failure in building docs and
coverage workflows
- trigger resetup miniconda & reinstall dpnp steps in case of failure
within `test_linux` job of conda package workflow

Note, the PR continues work initiated in #2254 and indented to make
public CI more stable.
github-actions bot added a commit that referenced this pull request Jan 13, 2025
The PR proposes to add fixes/improvements into the public CI:
- trigger resetup miniconda step on failure in building docs and
coverage workflows
- trigger resetup miniconda & reinstall dpnp steps in case of failure
within `test_linux` job of conda package workflow

Note, the PR continues work initiated in #2254 and indented to make
public CI more stable. 9d445ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants