-
Notifications
You must be signed in to change notification settings - Fork 22
Resolve issues in public CI #2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
38e2e49
to
42cafec
Compare
42cafec
to
49f957b
Compare
49f957b
to
74715ae
Compare
471d99a
to
66a78a8
Compare
66a78a8
to
41b8863
Compare
vlad-perevezentsev
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @antonwolfy
GH workflow for nightly run passed: |
github-actions bot
added a commit
that referenced
this pull request
Jan 11, 2025
The PR proposes to implement fixes/improvements into the public CI: - run `pre-commit` and `building docs` workflows on Ubuntu-22.04 (`ubuntu-latest` now refers to Ubuntu-24.04 where the workflows fail as for now) - use `fail-fast: false` rather than `continue-on-error: false` in workflow with night tests run (some jobs in strategy matrix may fail due to mamba/conda issues) _Note, the workflow will be reported as failed if any job fails._ - trigger rerun tests step on failure of `run_tests` step only in night tests workflow - trigger resetup minoconda step on failure in night tests and conda package workflows - build name of running job based on python and OS from strategy matrix - disable night tests workflow to be run in forked repositories Also the PR includes adaptation to the recent interface changes in dpctl implemented in [gh-1957](IntelPython/dpctl#1957). 303a203
6 tasks
antonwolfy
added a commit
that referenced
this pull request
Jan 13, 2025
The PR proposes to add fixes/improvements into the public CI: - trigger resetup miniconda step on failure in building docs and coverage workflows - trigger resetup miniconda & reinstall dpnp steps in case of failure within `test_linux` job of conda package workflow Note, the PR continues work initiated in #2254 and indented to make public CI more stable.
github-actions bot
added a commit
that referenced
this pull request
Jan 13, 2025
The PR proposes to add fixes/improvements into the public CI: - trigger resetup miniconda step on failure in building docs and coverage workflows - trigger resetup miniconda & reinstall dpnp steps in case of failure within `test_linux` job of conda package workflow Note, the PR continues work initiated in #2254 and indented to make public CI more stable. 9d445ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to implement fixes/improvements into the public CI:
pre-commit
andbuilding docs
workflows on Ubuntu-22.04 (ubuntu-latest
now refers to Ubuntu-24.04 where the workflows fail as for now)fail-fast: false
rather thancontinue-on-error: false
in workflow with night tests run (some jobs in strategy matrix may fail due to mamba/conda issues)Note, the workflow will be reported as failed if any job fails.
run_tests
step only in night tests workflowAlso the PR includes adaptation to the recent interface changes in dpctl implemented in gh-1957.