Statistics funcs cov #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rubtsowa please save original paths, file names and file contents (as it possible) when you add the tests. Please look at these changes for better explanation what I mean. |
shssf
reviewed
Sep 7, 2020
| cpdef dparray dpnp_cov(dparray array1): | ||
| # behaviour of original numpy | ||
| if array1.ndim > 2: | ||
| raise ValueError("array has more than 2 dimensions") |
shssf
reviewed
Sep 7, 2020
|
|
||
| is_dparray1 = isinstance(in_array1, dparray) | ||
|
|
||
| if (not use_origin_backend(in_array1) and is_dparray1): |
shssf
approved these changes
Sep 7, 2020
AlexanderKalistratov
added a commit
to AlexanderKalistratov/dpnp
that referenced
this pull request
Nov 12, 2024
AlexanderKalistratov
added a commit
to AlexanderKalistratov/dpnp
that referenced
this pull request
Dec 4, 2024
AlexanderKalistratov
added a commit
to AlexanderKalistratov/dpnp
that referenced
this pull request
Dec 4, 2024
antonwolfy
added a commit
that referenced
this pull request
Jan 13, 2025
The PR proposes to add fixes/improvements into the public CI: - trigger resetup miniconda step on failure in building docs and coverage workflows - trigger resetup miniconda & reinstall dpnp steps in case of failure within `test_linux` job of conda package workflow Note, the PR continues work initiated in #2254 and indented to make public CI more stable.
github-actions bot
added a commit
that referenced
this pull request
Jan 13, 2025
The PR proposes to add fixes/improvements into the public CI: - trigger resetup miniconda step on failure in building docs and coverage workflows - trigger resetup miniconda & reinstall dpnp steps in case of failure within `test_linux` job of conda package workflow Note, the PR continues work initiated in #2254 and indented to make public CI more stable. 9d445ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naive implementation np.cov with using of already implemented another functions is added.
Tests for statistics functions are added, all that are available in statistics_tests except few specific (cupy.core._accelerator).
Paths and file names are changed to be the same as in original test suite, test file for numpy.mean is replaced by original.
3 test for 'mean' are passed as it was before changes.
+2 passed tests from 'histogram'.
+2 passed tests from 'correlation' (np.cov).