Skip to content

implement dpnp.argmin and dpnp.argmax using dpctl.tensor #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 23, 2023
Merged

implement dpnp.argmin and dpnp.argmax using dpctl.tensor #1610

merged 17 commits into from
Nov 23, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 27, 2023

In this PR, dpnp.argmax and dpnp.argmin are implemented using their dpctl.tensor counterparts.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 27, 2023
@vtavana vtavana requested a review from antonwolfy October 27, 2023 04:34
antonwolfy
antonwolfy reviewed Oct 27, 2023
View reviewed changes
@vtavana vtavana changed the base branch from max_min to diag_vander_ptp_trace October 27, 2023 17:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the diag_vander_ptp_trace branch from 4285f71 to 265b286 Compare October 30, 2023 17:08
@vtavana vtavana force-pushed the diag_vander_ptp_trace branch from 265b286 to 1e50360 Compare October 31, 2023 18:15
@vtavana vtavana force-pushed the diag_vander_ptp_trace branch from 1e50360 to bd6fcb0 Compare November 8, 2023 17:46
@vtavana vtavana requested a review from npolina4 November 9, 2023 00:31
npolina4
npolina4 reviewed Nov 9, 2023
View reviewed changes
@vtavana vtavana force-pushed the diag_vander_ptp_trace branch 2 times, most recently from 93b6b10 to 34a1407 Compare November 16, 2023 18:35
Base automatically changed from diag_vander_ptp_trace to master November 20, 2023 20:51
antonwolfy
antonwolfy reviewed Nov 20, 2023
View reviewed changes
antonwolfy
antonwolfy reviewed Nov 21, 2023
View reviewed changes
antonwolfy
antonwolfy approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana LGTM!

@vtavana vtavana merged commit 7d0815f into master Nov 23, 2023
@vtavana vtavana deleted the argmin_argmax branch November 23, 2023 18:53
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @npolina4 @antonwolfy