Skip to content

Commit 2028535

Browse files
committed
add tests for negative use cases to improve covergae
1 parent 6c3991d commit 2028535

File tree

1 file changed

+29
-11
lines changed

1 file changed

+29
-11
lines changed

tests/test_search.py

Lines changed: 29 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import dpctl.tensor as dpt
12
import numpy
23
import pytest
34
from numpy.testing import assert_allclose
@@ -47,23 +48,40 @@ def test_argmax_argmin_bool(axis, keepdims):
4748
assert_allclose(dpnp_res, np_res)
4849

4950

50-
@pytest.mark.parametrize("axis", [None, 0, 1, -1, 2, -2])
51-
@pytest.mark.parametrize("keepdims", [False, True])
52-
@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
53-
def test_argmax_argmin_out(axis, keepdims, dtype):
54-
a = numpy.arange(768, dtype=dtype).reshape((4, 4, 6, 8))
51+
def test_argmax_argmin_out():
52+
a = numpy.arange(6).reshape((2, 3))
5553
ia = dpnp.array(a)
5654

57-
np_res = numpy.argmax(a, axis=axis, keepdims=keepdims)
55+
np_res = numpy.argmax(a, axis=0)
5856
dpnp_res = dpnp.array(numpy.empty_like(np_res))
59-
dpnp.argmax(ia, axis=axis, keepdims=keepdims, out=dpnp_res)
57+
dpnp.argmax(ia, axis=0, out=dpnp_res)
58+
assert_allclose(dpnp_res, np_res)
6059

61-
assert dpnp_res.shape == np_res.shape
60+
dpnp_res = dpt.asarray(numpy.empty_like(np_res))
61+
dpnp.argmax(ia, axis=0, out=dpnp_res)
6262
assert_allclose(dpnp_res, np_res)
6363

64-
np_res = numpy.argmin(a, axis=axis, keepdims=keepdims)
64+
dpnp_res = numpy.empty_like(np_res)
65+
with pytest.raises(TypeError):
66+
dpnp.argmax(ia, axis=0, out=dpnp_res)
67+
68+
dpnp_res = dpnp.array(numpy.empty((2, 3)))
69+
with pytest.raises(ValueError):
70+
dpnp.argmax(ia, axis=0, out=dpnp_res)
71+
72+
np_res = numpy.argmin(a, axis=0)
6573
dpnp_res = dpnp.array(numpy.empty_like(np_res))
66-
dpnp.argmin(ia, axis=axis, keepdims=keepdims, out=dpnp_res)
74+
dpnp.argmin(ia, axis=0, out=dpnp_res)
75+
assert_allclose(dpnp_res, np_res)
6776

68-
assert dpnp_res.shape == np_res.shape
77+
dpnp_res = dpt.asarray(numpy.empty_like(np_res))
78+
dpnp.argmin(ia, axis=0, out=dpnp_res)
6979
assert_allclose(dpnp_res, np_res)
80+
81+
dpnp_res = numpy.empty_like(np_res)
82+
with pytest.raises(TypeError):
83+
dpnp.argmin(ia, axis=0, out=dpnp_res)
84+
85+
dpnp_res = dpnp.array(numpy.empty((2, 3)))
86+
with pytest.raises(ValueError):
87+
dpnp.argmin(ia, axis=0, out=dpnp_res)

0 commit comments

Comments
 (0)