Add approvals, approve & unapprove API's #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbourigault
reviewed
Jul 17, 2017
| * | ||
| * @return mixed | ||
| */ | ||
| public function unApprove($project_id, $mr_id) |
There was a problem hiding this comment.
Use unapprove here please. Also use $merge_request_iid.
| * | ||
| * @return mixed | ||
| */ | ||
| public function approvals($project_id, $mr_id) |
There was a problem hiding this comment.
Could you use $merge_request_iid here instead of $mr_id? Full names are better than abbreviations and iid as it carry some information to the API user.
| * | ||
| * @return mixed | ||
| */ | ||
| public function approve($project_id, $mr_id) |
|
@fbourigault See #203 |
fbourigault
added a commit
that referenced
this pull request
Jul 20, 2017
Apply #201 suggested fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @m4tthumphrey ,
It lacks what to for approve or know the state of approval, here is a PR to add these features:
Regards