Skip to content

Commit 1d8e771

Browse files
authored
Merge pull request #203 from m4tthumphrey/suggested-chan
Apply #201 suggested fixes
2 parents 6cc87d5 + 6a62720 commit 1d8e771

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lib/Gitlab/Api/MergeRequests.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,9 @@ public function closesIssues($project_id, $mr_id)
235235
*
236236
* @return mixed
237237
*/
238-
public function approvals($project_id, $mr_id)
238+
public function approvals($project_id, $merge_request_iid)
239239
{
240-
return $this->get($this->getProjectPath($project_id, 'merge_requests/'.$this->encodePath($mr_id).'/approvals'));
240+
return $this->get($this->getProjectPath($project_id, 'merge_requests/'.$this->encodePath($merge_request_iid).'/approvals'));
241241
}
242242

243243
/**
@@ -246,9 +246,9 @@ public function approvals($project_id, $mr_id)
246246
*
247247
* @return mixed
248248
*/
249-
public function approve($project_id, $mr_id)
249+
public function approve($project_id, $merge_request_iid)
250250
{
251-
return $this->post($this->getProjectPath($project_id, 'merge_requests/'.$this->encodePath($mr_id).'/approve'));
251+
return $this->post($this->getProjectPath($project_id, 'merge_requests/'.$this->encodePath($merge_request_iid).'/approve'));
252252
}
253253

254254
/**
@@ -257,8 +257,8 @@ public function approve($project_id, $mr_id)
257257
*
258258
* @return mixed
259259
*/
260-
public function unApprove($project_id, $mr_id)
260+
public function unapprove($project_id, $merge_request_iid)
261261
{
262-
return $this->post($this->getProjectPath($project_id, 'merge_requests/'.$this->encodePath($mr_id).'/unapprove'));
262+
return $this->post($this->getProjectPath($project_id, 'merge_requests/'.$this->encodePath($merge_request_iid).'/unapprove'));
263263
}
264264
}

0 commit comments

Comments
 (0)