examples/push: fix constructor syntax #50
Conversation
examples/push: fix constructor syntax
| @@ -20,8 +20,8 @@ | |||
| #include <Firebase.h> | |||
|
|
|||
| // create firebase client. | |||
| Firebase fbase("example.firebaseio.com") | |||
| .auth("secret_or_token"); | |||
| Firebase fbase = Firebase("example.firebaseio.com") | |||
There was a problem hiding this comment.
This syntax is odd for c++. You are basically telling the compiler to create a empty Firebase object "fbase" then copy another anonymous Firebase object into it. So two objects + copy constructor. Copy elision should optimize this away but depending on a compiler optimization looks odd to c++ eyes.
There was a problem hiding this comment.
Yes, I just restored the example the way it was before.
I think moving forward we should embrace two-step initialization, which seems to be a common pattern in Arduino-land.
Firebase fbase;
void setup() {
fbase.begin("host", "auth");
}
WDYT?
There was a problem hiding this comment.
It is a little more combersome but I can see how it is useful with the setup() loop() cycle. We could provide both options.
How about we call it "setup()" instead of begin though. to match the arduino function name.
Most of Arduino object have a That's why I initially suggested this :) |
No description provided.