Skip to content

442: maintain references between socket.io connection events #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

danatcofo
Copy link
Contributor

@danatcofo danatcofo commented Oct 6, 2020

fixes #442

remove deletes of modules during disconnect
add delete of hostHook during disconnect
check if modules exist before importing them during connect
move local caches of modules into global scope.

ElectronNET#442

remove deletes of modules during disconnect
add delete of hostHook during disconnect
check if modules exist before importing them curring connect
move local caches of modules into global scope.
@GregorBiswanger GregorBiswanger self-assigned this Nov 18, 2020
@GregorBiswanger GregorBiswanger added this to the 10.5.1 milestone Nov 18, 2020
@GregorBiswanger
Copy link
Member

Thanks for your PR!

Can you please change the var declarations to const or let.
var should no longer be used. Then the function declaration back into an arrow function.

Were you able to test a refresh of the app with your code or that it still runs in the event of a disconnect?

Then unfortunately we have a couple of conflicts that would have to be resolved for a merge.

Thanks!

@danatcofo
Copy link
Contributor Author

I was able to test this locally with a forced connection close. it reconnected without issue and all references were maintained without breaking logic links across disconnect/connect.

I'll get this updated for your coding style preferences.

@GregorBiswanger GregorBiswanger merged commit 49e21de into ElectronNET:master Jan 11, 2021
@GregorBiswanger
Copy link
Member

I merged everything, but the Test WebApp only shows the splashscreen. The application itself no longer responds. Could it be now that the events are no longer listening at the right time?

Please need a solution so that we can roll out the next update.

Thank you very much for your commitment

@GregorBiswanger
Copy link
Member

Possibly delete the ElectronNET.WebApp/obj/host folder, so that you get the current host version.

@GregorBiswanger
Copy link
Member

Okay, the problem is that the latest Socket.IO version is not supported by our outdated .net library for Socket.IO.. 🤔😔

So it was my mistake, I have to continue to use the old version ..

@danatcofo
Copy link
Contributor Author

yah, easy to lose something in the middle of multiple changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

socket.io connection event after disconnect event loses all browserWindow references
2 participants