socket.io connection event after disconnect event loses all browserWindow references

[MopsieX]

• Version: 9.31.1

• Target: Windows 10

When the socket in main.js gets disconnected it deletes all the requires and then it will connect again. When the connection event fires again it reinitializes all of the requires however the windows[] and window variable aren't ever set in browserWindows.js. To fix it the main.js just needs to copy the references of all the windows before it deletes the require cache for browserWindows.js then after the browserWindows.js gets reinitialized/required the main.js needs to pass the windows to it.
Sorry for the bad explanation. I'm terrible at explaining things. If you have any questions or need clarification let me know.

[Velorien]

This seems like a probable cause for #421

[MopsieX]

This seems like a probable cause for #421

Yup you are correct. I get that same error message you get once it happens. Thanks for linking it and having a picture of the error in your bug report. I forgot to include a screenshot of the error message when the bug happens.
Hopefully 9.31.2 is released today with this fixed.

[MopsieX]

@GregorBiswanger @Velorien Unfortunately this isn't fixed in the newest version so the problem is still here.

[GregorBiswanger]

Hey Community, we have released version 9.31.2 with the electron-builder fix! In addition, I have improved the socket problems again and updated to Electron 9.0.5.

Please remove in your obj folder the Host and Desktop folder and try again with the newest Electron.NET API and CLI in 9.31.2.

[MopsieX]

Thanks I will do that!

[MopsieX]

@GregorBiswanger It disconnects less often now but on reconnect the property windows never gets populated with the existing windows which means the app needs to be restarted.

[MopsieX]

I think I fixed the bug in the source. I'm testing it now but I need to wait for a disconnect.

[MopsieX]

Never mind I was wrong. It's a lot harder to fix than I thought it was. I've learned a lot about how Electron.Net works so tomorrow I should have more luck fixing it.

[freosc]

I added
socket.removeAllListeners();
to the socket.on('disconnect', function (reason) function in main.js
But that doesn't seem to help.
After 10 socket disconnect/reconnect I get:

16:36:22.056 > stdout: Socket Disconnect! ping timeout
16:36:22.058 > Got disconnect! Reason: transport close
16:36:25.125 > ASP.NET Core Application connected... global.electronsocket ry2ZzmrkaKieYTSaAAAJ 2020-07-13T14:36:25.125Z
16:36:25.141 > (node:33040) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 window-all-closed listeners added to [App]. Use emitter.setMaxListeners() to increase limit
16:36:25.142 > stdout: BridgeConnector connected!

I'm not sure if it's related to the removeAllListeners or not. It's hard to debug this code and reproduce 10 disconnects.

[HermesNew]

We also encountered the same issue, this issue is more urgent.