Skip to content

update integration test log snapshot files #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2022
Merged

update integration test log snapshot files #252

merged 1 commit into from
Sep 27, 2022

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Sep 27, 2022 •
edited
Loading

What does this PR do?

Update the integration test log snapshot files.

Motivation

new field http.useragent was added

Testing Guidelines

Ran the integration tests with the new snapshots

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 marked this pull request as ready for review September 27, 2022 18:54
@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner September 27, 2022 18:54
@joeyzhao2018 joeyzhao2018 mentioned this pull request Sep 27, 2022
Closed
11 tasks
@joeyzhao2018 joeyzhao2018 requested a review from agocs September 27, 2022 18:56
agocs
agocs approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@agocs agocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeyzhao2018 joeyzhao2018 merged commit cb64278 into main Sep 27, 2022
@joeyzhao2018 joeyzhao2018 deleted the joey/integration_test_update branch September 27, 2022 19:36
joeyzhao2018 added a commit that referenced this pull request Sep 27, 2022
@joeyzhao2018
update integration test log snapshot files (#252)
7304987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agocs agocs agocs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyzhao2018 @agocs