Skip to content

authorizer spans #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

authorizer spans #250

wants to merge 11 commits into from

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Sep 16, 2022

What does this PR do?

Fixes DataDog/serverless-plugin-datadog#252 for Python
Ticket: SLS-2499, RFC

Motivation

This solution is essentially adding an extra inferred span that connects the current two traces, i.e. the authorizer function trace and the main function trace, into one trace.
apigateway authorizer

Implementation

  • When in the authorizer function, inject the necessary trace information and the timestamp information into the returned response
  • When in the main function, extract the information injected during authorizer function execution and create an inferred span based on it.
  • More Details: google doc link

Testing Guidelines

  • Unittests added
  • Ran integration tests
  • Datadog links for testing evidence :
Rest Api (API Gateway V1) Http Api (API Gateway V2) Websocket
Request Type Authorizer First invocation / Cached case First invocation / Cached case $connect with authorizer / main func
Token Type Authorizer First invocation / Cached case jwt authorizer doesn't apply here not available

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 marked this pull request as ready for review September 27, 2022 14:34
@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner September 27, 2022 14:34
@joeyzhao2018 joeyzhao2018 deleted the joey/authorizer_spans branch October 26, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authorizer traces not correlated with API gateway traces
1 participant