fix: no clarfication on team dashboard

[cubercsl]

No description provided.

[vmcj]

@cubercsl for what type of clarifications was this a fix?

[cubercsl]

Clarification associates either problem or contest. The existing code selects contestproblem and contest, which selects nothing :(. So team will see nothing on their team home, but if they enable notification, they can click it and jump to the clarification URL and see its content.

[cubercsl]

This is our hotfix between warmup and contest, but this may not occur in demoweb, I will verify this later.

[vmcj]

Clarification associates either problem or contest. The existing code selects contestproblem and contest, which selects nothing :(. So team will see nothing on their team home, but if they enable notification, they can click it and jump to the clarification URL and see its content.

From a quick glance at the code I would assume the LeftJoin would already have to do this. The only reason for not merging this would be the speed penalty though so let's see if we can reproduce this somewhere and I'll take a look later this week.

[cubercsl]

@vmcj I have repro this on demoweb, pls check it. Both clarification and clarification requests (not reference
to a problem) can not be seen in the team home, but when you login as team, you can open the clarification by url https://www.domjudge.org/demoweb/team/clarifications/193

[vmcj]

I'll give the rest a bit of time to look at it but I agree its broken.

[eldering]

General question about the existing code:
When would ever cp.contest match $contest, but c.contest not? That is, why can't we just have

->andWhere('c.contest = :contest')

[nickygerritsen]

When you unlink a problem from a contest is the only way I can think of.

[moesoha]

this was implemented in 0219d8e

[cubercsl]

@Dup4 told me that the clarifications (send to all, with specific problem) can be displayed correctly on the team homepage in his shadow (of my instance). The picture below is his screenshot in shadow (login with DOMJudge team member)

But the general issue and technical issue (i.e. without specific problem) can not be shown.

[moesoha]

I found that we misunderstood the motivation of the ->andWhere('cp.contest = :contest') after ->andWhere('c.contest = :contest'), so this PR is not good.

At first, I think ->andWhere('cp.contest = :contest') is used to support a problem in multiple contests (like one problem exists in Div.1 and Div.2). By this way, clarification can be decoupled with contests, and can be associated with either Contest or Problem. And a clarification associated with a problem can be synced to all contests.

But since I investigated the codes today, I found the commit implements above codes: 0219d8e. This code fixes the issue mentioned in #2279, but I don't think this is a solution. Obviously, @vmcj misunderstood the usage of LEFT JOIN, and the fix for this issue is actually an accident. I'd like to draft a new PR to fix #2279 again.