Skip to content

Fix seeEmailIsSent #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Fix seeEmailIsSent #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Codeception/Module/Symfony.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ public function seeEmailIsSent($expectedCount = null)
$realCount = count($mailCollector->getEvents()->getMessages());
}

if ($expectedCount) {
if ($expectedCount !== null) {
$this->assertEquals($expectedCount, $realCount, sprintf(
'Expected number of sent emails was %d, but in reality %d %s sent.',
$expectedCount, $realCount, $realCount === 2 ? 'was' : 'were'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this condition be $realCount === 1 ? 'was' : 'were' ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naktibalda Hmm, apparently it's been like this since the function was created. I'm not sure if it has to do with how Swift Mailer vs Symfony Mailer works.

should i change it?

Expand Down