Fix seeEmailIsSent #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naktibalda
reviewed
Nov 24, 2020
| @@ -548,7 +548,7 @@ public function seeEmailIsSent($expectedCount = null) | |||
| $realCount = count($mailCollector->getEvents()->getMessages()); | |||
| } | |||
|
|
|||
| if ($expectedCount) { | |||
| if ($expectedCount !== null) { | |||
| $this->assertEquals($expectedCount, $realCount, sprintf( | |||
| 'Expected number of sent emails was %d, but in reality %d %s sent.', | |||
| $expectedCount, $realCount, $realCount === 2 ? 'was' : 'were' | |||
There was a problem hiding this comment.
Shouldn't this condition be $realCount === 1 ? 'was' : 'were' ?
There was a problem hiding this comment.
@Naktibalda Hmm, apparently it's been like this since the function was created. I'm not sure if it has to do with how Swift Mailer vs Symfony Mailer works.
should i change it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55