-
Notifications
You must be signed in to change notification settings - Fork 88
Added C# solutions for Chapter 1 (Two Pointers) #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added C# solutions for Chapter 1 (Two Pointers) #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @emseto, thanks for making the first PR to the C# solutions!
I noticed you used public partial class Solution
. Are there any downsides to using public class Solution
instead? We want to go with the more familiar option.
Hi @Destiny-02, thank you for taking a look at the PR! The reason why I used There are a couple of constraints in C# to note:
Because I wasn't sure what to name each class, I settled on There are a few ways of remedying this, including:
If each file is going to be self-contained, then I can go ahead and update |
Thanks for the explanation @emseto! In this case, we'd like to use |
Hi @Destiny-02 , sounds good and thank you for the clarification! I've updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This follows the naming conventions as described in C# identifier naming rules and conventions.
I'm open to modifying class names if there's something more appropriate. Added unit tests for Chapter 1: Two Pointers here.