Allow subscriber message retention policy to be customised #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-p
force-pushed
the
feature/expose-message-clearing
branch
from
9139a3b to
3c5bb9b
Compare
|
@facontidavide is this alternative ok. is very little overhead and i think no real added complexity |
|
Closing in favour of #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create overrideable protected function that the implementing action can use to change message retention behaviour. Implementing in such away gives implementer a lot of control with limited overhead in the abstract class. Default behaviour remains unchanged
Alternative to #42