Skip to content

Cellular: Fix cellular specific Greentea tests #9472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AriParkkila
Copy link

Description

Fix cellular specific Greentea tests after feature-branch was rebased to master.

Tested with UBLOX_C027.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@jarvte

@ciarmcom ciarmcom requested review from jarvte and a team January 23, 2019 14:00
@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@AriParkkila AriParkkila force-pushed the cellular-refactor-greentea branch from becf576 to 9583966 Compare January 25, 2019 07:35
@cmonr
Copy link
Contributor

cmonr commented Jan 25, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 25, 2019

Test run: FAILED

Summary: 4 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@AriParkkila
Copy link
Author

@ciarmcom some jobs are failing here, but it's hard to say actual reason, see e.g. https://mbed-os.mbedcloudtesting.com/job/mbed-os-ci_mbed2-build-GCC_ARM/1304/

@jarvte
Copy link
Contributor

jarvte commented Jan 28, 2019

@cmonr @ciarmcom can you please re-start? There are other issues pending on this pr.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 28, 2019

look at the regular builds, there are failures like : [DEBUG] Errors: Error: L6218E: Undefined symbol thunk{v:0,-32} to EMACInterface::get_mac_address() (referred from BUILD/tests/MTB_ADV_WISE_1530/ARM/targets/TARGET_WICED/TOOLCHAIN_ARM/TARGET_MTB_ADV_WISE_1530/libwiced_drivers.ar(WicedInterface.o)). . I believe I have seen this in another PR - 9457 ? Isn't this caused by rebase?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 28, 2019

@cmonr @ciarmcom can you please re-start? There are other issues pending on this pr.

Please confirm feature branch builds locally for ARM or IAR

@AriParkkila
Copy link
Author

@0xc0170 please restart CI build

@cmonr
Copy link
Contributor

cmonr commented Jan 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 28, 2019

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2019

The remaining failures are for mbed 2 , can you review these?

@AriParkkila
Copy link
Author

@0xc0170 cellular was missing NSAPI compile exclusions for mbed 2, please restart build.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 29, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr removed the needs: work label Jan 29, 2019
@0xc0170 0xc0170 merged commit 87851f3 into ARMmbed:feature-cellular-refactor Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants